From d0581f881c4072ef0ac453167a98dc3bc0d87d86 Mon Sep 17 00:00:00 2001 From: Leo C Date: Wed, 20 Aug 2014 14:01:11 +0200 Subject: enum command_ret_t --> typedef --- avr/command.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'avr/command.c') diff --git a/avr/command.c b/avr/command.c index df4bb98..9eb0ed2 100644 --- a/avr/command.c +++ b/avr/command.c @@ -67,11 +67,11 @@ int cmd_tbl_item_count(void) * for long help messages */ -int _do_help(cmd_tbl_t *cmd_start, int cmd_items, cmd_tbl_t * cmdtp, +command_ret_t _do_help(cmd_tbl_t *cmd_start, int cmd_items, cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[]) { uint_fast8_t i; - int rcode = 0; + command_ret_t rcode = CMD_RET_SUCCESS; (void) flag; @@ -94,7 +94,7 @@ int _do_help(cmd_tbl_t *cmd_start, int cmd_items, cmd_tbl_t * cmdtp, /* allow user abort */ if (ctrlc ()) - return 1; + return CMD_RET_FAILURE; if (usage == NULL) continue; #ifdef GCC_BUG_61443 @@ -104,19 +104,19 @@ int _do_help(cmd_tbl_t *cmd_start, int cmd_items, cmd_tbl_t * cmdtp, cmd_array[i]->name, usage); #endif } - return 0; + return CMD_RET_SUCCESS; } /* * command help (long version) */ for (i = 1; i < argc; ++i) { if ((cmdtp = find_cmd_tbl (argv[i], cmd_start, cmd_items )) != NULL) { - rcode |= cmd_usage(cmdtp); + rcode = cmd_usage(cmdtp); } else { printf_P(PSTR("Unknown command '%s' - try 'help'" " without arguments.\n\n"), argv[i] ); - rcode = 1; + rcode = CMD_RET_FAILURE; } } return rcode; @@ -162,7 +162,7 @@ cmd_tbl_t *find_cmd (const char *cmd) } -int cmd_usage(const FLASH cmd_tbl_t *cmdtp) +command_ret_t cmd_usage(const FLASH cmd_tbl_t *cmdtp) { // printf("%s - %s\n\n", cmdtp->name, cmdtp->usage); print_usage_line(cmdtp->name, cmdtp->usage); @@ -181,13 +181,13 @@ int cmd_usage(const FLASH cmd_tbl_t *cmdtp) if (!cmdtp->help) { my_puts_P(PSTR(" - No additional help available.\n")); - return 1; + return CMD_RET_FAILURE; } my_puts_P(cmdtp->help); my_puts_P(PSTR("\n")); #endif /* CONFIG_SYS_LONGHELP */ - return 1; + return CMD_RET_FAILURE; } #ifdef CONFIG_AUTO_COMPLETE @@ -459,31 +459,31 @@ int cmd_auto_complete(const FLASH char *const prompt, char *buf, int *np, int *c * @param argv Arguments * @return 0 if command succeeded, else non-zero (CMD_RET_...) */ -static int cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +command_ret_t cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { - int result; + command_ret_t result; result = (cmdtp->cmd)(cmdtp, flag, argc, argv); - if (result) + if (result != CMD_RET_SUCCESS) debug("Command failed, result=%d\n", result); return result; } -enum command_ret_t cmd_process(int flag, int argc, char * const argv[], +command_ret_t cmd_process(int flag, int argc, char * const argv[], uint_fast8_t *repeatable) { - enum command_ret_t rc = CMD_RET_SUCCESS; + command_ret_t rc = CMD_RET_SUCCESS; cmd_tbl_t *cmdtp; /* Look up command in command table */ cmdtp = find_cmd(argv[0]); if (cmdtp == NULL) { printf_P(PSTR("Unknown command '%s' - try 'help'\n"), argv[0]); - return 1; + return CMD_RET_FAILURE; } if (!cmdtp->cmd) { debug("### Command '%s' found, but ->cmd == NULL \n", argv[0]); - return 1; + return CMD_RET_FAILURE; } /* found - check max args */ -- cgit v1.2.3