]>
Commit | Line | Data |
---|---|---|
c25f6a44 L |
1 | Re: Inconsistency in CP/M Kermit Version 4.09 |
2 | ||
3 | Problem: Comments in the source-files indicate that the routine which | |
4 | processes the "Set Port" command, "prtset" in CPSCOM.ASM, returns | |
5 | the port value in the register pair DE for the system-dependent | |
6 | routine to process. In fact, the value is returned in the HL | |
7 | register pair. | |
8 | Solution: Either (1) put a "xchg" instruction after the "shld port" | |
9 | instruction in "prtset" and modify all port-setting routines which | |
10 | expect the port parameter in HL, e.g., that for those systems using | |
11 | iobyte redirection, to get the value from DE (this would be, I | |
12 | suppose, philosophically correct since this would correspond to | |
13 | the way the baud-rate-setting routine handles things) or | |
14 | (2) change the comments in CPSDAT.ASM and CPXLNK.ASM to show the | |
15 | return value from "prtset" in HL and modify the "sysprt" routines | |
16 | which expect the port value in DE to get it from HL. I chose this | |
17 | approach as it appeared that this would involve less code changes | |
18 | (the only system I saw getting port values from DE was the Lobo). | |
19 | Below are FILCOMs of the appropriate files showing these changes. | |
20 | ||
21 | File 1) DSKE:CPSDAT.ASM[10,50,KERMIT,CPM] created: 1925 26-Aug-89 | |
22 | File 2) DSKE:CPSDAT.ASM[10,50] created: 1202 31-Aug-89 | |
23 | ||
24 | 1)4 ; called with value from table in DE | |
25 | 1) sysscr: jmp $-$ ; screen setup for file transfer | |
26 | **** | |
27 | 2)4 ; called with value from table in HL | |
28 | 2) sysscr: jmp $-$ ; screen setup for file transfer | |
29 | ************** | |
30 | ||
31 | File 1) DSKE:CPXLNK.ASM[10,50,KERMIT,CPM] created: 1826 26-Aug-89 | |
32 | File 2) DSKE:CPXLNK.ASM[10,50] created: 1157 31-Aug-89 | |
33 | ||
34 | 1)1 ; called with value from table in DE | |
35 | 1) jmp sysscr ; screen setup for file transfer | |
36 | **** | |
37 | 2)1 ; called with value from table in HL | |
38 | 2) jmp sysscr ; screen setup for file transfer | |
39 | ************** | |
40 | ||
41 | File 1) DSKE:CPXSY2.ASM[10,50,KERMIT,CPM] created: 0743 28-Aug-89 | |
42 | File 2) DSKE:CPXSY2.ASM[10,50] created: 1210 31-Aug-89 | |
43 | ||
44 | 1)4 mov a,e ;[hh] get the data port value and store at | |
45 | 1) sta outmd3+1 ;[hh] the two places we use... | |
46 | **** | |
47 | 2)4 mov a,l ;[hh] get the data port value and store at | |
48 | 2) sta outmd3+1 ;[hh] the two places we use... | |
49 | ************** | |
50 | 1)4 mov a,d ;[hh] now get the baud rate port value | |
51 | 1) sta getbd+1 ;[hh] store it in the two places we use... | |
52 | **** | |
53 | 2)4 mov a,h ;[hh] now get the baud rate port value | |
54 | 2) sta getbd+1 ;[hh] store it in the two places we use... | |
55 | ************** | |
56 | ||
57 | E-mail replies may be sent to me via Bitnet at mailer@uwalocke. | |
58 | Please place on the subject line the phrase <dec10%"bpa"> (less the angle- | |
59 | brackets). | |
60 | -- Mike Freeman (routing MORF); Bonneville Power Administration; P.O. Box | |
61 | 491; Vancouver, Wa 98666; Telephone (206)690-2307 -- | |
62 | \0\0 |