cli.c: bugfix in cli_parse_line(): correct nargs

[z180-stamp.git] / avr / cli.c

diff --git a/avr/cli.c b/avr/cli.c
index b310f793d97eb54d85db24129eecc4bb6996687b..e66554ac0ed58240966d70d8ba9c1c5e09660733 100644 (file)
--- a/avr/cli.c
+++ b/avr/cli.c
@@ -1,3 +1,16 @@
+/*
+ * (C) Copyright 2014 Leo C. <erbl259-lmu@yahoo.de>
+ *
+ * (C) Copyright 2000
+ * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
+ *
+ * Add to readline cmdline-editing by
+ * (C) Copyright 2005
+ * JinHua Luo, GuangDong Linux Center, <luo.jinhua@gd-linux.com>
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
 #include "common.h"
 
 #include <string.h>
@@ -14,6 +27,9 @@
 #include "con-utils.h"
 #include "cli.h"
 
+
+/* FIXME: Quoting problems */
+
 #define DEBUG_PARSER   0       /* set to 1 to debug */
 
 #define debug_parser(fmt, args...)             \
@@ -21,26 +37,78 @@
 
 static int cli_parse_line(char *line, char *argv[])
 {
-       static const FLASH char delim[] = {" \t"};
-
-       char *ptr;
+       uint_fast8_t state = 0;
        uint_fast8_t nargs = 0;
+       char *inp, *outp;
+       char c, quote;
+
+       debug_parser("%s: \"%s\"\n", __func__, line);
+
+       for (outp = inp = line, quote = '\0'; (c = *inp) != '\0'; inp++) {
+
+               switch (state) {
+               case 0:                                         /* before arg string, waiting for arg start */
+                       if (isblank(c))
+                               continue;
+
+                       argv[nargs++] = inp;    /* begin of argument string     */
+                       outp = inp;
+                       state = 1;
+                       /* fall thru */
+
+               case 1:                                         /* in arg string, waiting for end of arg string */
+                       if (c == '\\') {
+                               ++state;
+                               continue;
+                       }
+                       if (c == '\"' || c == '\'') {
+                               quote = c;
+                               state = 3;
+                               continue;
+                       }
+                       if (isblank(c)) {
+                               c = '\0';
+                               state = 0;
+                       }
+                       break;
 
-       debug_parser("parse_line: \"%s\"\n", line);
+               case 3:                                         /* in quote */
+                       if (c == '\\' && quote == '\"') {
+                               ++state;
+                               continue;
+                       }
+                       if (c == quote) {
+                               state = 1;
+                               continue;
+                       }
+                       break;
+
+               case 2:                                         /* waiting for next char */
+               case 4:
+                       --state;
+                       break;
 
-       ptr = strtok_P(line, delim);
-       while(nargs < CONFIG_SYS_MAXARGS && ptr != NULL) {
-               argv[nargs++] = ptr;
-               ptr = strtok_P(NULL, delim);
+               }
+
+               if (nargs > CONFIG_SYS_MAXARGS) {
+                       --nargs;
+                       break;
+               }
+               *outp++ = c;
        }
 
-       if (ptr != NULL)
+       if (*inp != '\0')
                printf_P(PSTR("** Too many args (max. %d) **\n"), CONFIG_SYS_MAXARGS);
 
+       *outp = '\0';
        argv[nargs] = NULL;
-       debug_parser("parse_line: nargs=%d\n", nargs);
-
+       debug_parser("%s: nargs=%d\n", __func__, nargs);
+#if 0
+       for (int i = 0; i < nargs; i++)
+               debug_parser("%s: arg %d: >%s<\n", __func__, i, argv[i]);
+#endif
        return nargs;
+
 }
 
 static
@@ -61,7 +129,8 @@ char *process_macros(char *input, char *output)
 
        for(uint_fast8_t pass = 0; pass < 2; pass++)
        {
-               uint_fast8_t state = 0;         /* 0 = waiting for '$'  */
+               uint_fast8_t state = 0;
+               /* 0 = waiting for '$'  */
                /* 1 = waiting for '{' */
                /* 2 = waiting for '}' */
                /* 3 = waiting for ''' */
@@ -75,22 +144,13 @@ char *process_macros(char *input, char *output)
                }
 
                inp = input;
-               prev = '\0';            /* previous character   */
 
-               debug_parser("[PROCESS_MACROS] INPUT len %d: \"%s\"\n", strlen(inp),
-                            inp);
+               debug_parser("[PROCESS_MACROS] INPUT len %d: \"%s\"\n",
+                                               strlen(inp), inp);
+
+               for (prev = '\0'; (c = *inp++) != '\0'; prev = c) {
 
-               while ((c = *inp++) != '\0') {
 
-                       if (state != 3) {
-                               /* remove one level of escape characters */
-                               if ((c == '\\') && (prev != '\\')) {
-                                       if (*inp == '\0')
-                                               break;
-                                       prev = c;
-                                       c = *inp++;
-                               }
-                       }
 
                        switch (state) {
                        case 0: /* Waiting for (unescaped) $    */
@@ -98,19 +158,19 @@ char *process_macros(char *input, char *output)
                                        state = 3;
                                        break;
                                }
-                               if ((c == '$') && (prev != '\\'))
+                               if ((c == '$') && (prev != '\\')) {
                                        state++;
-                               else
-                                       append_char(pass, &outp, c);
+                                       continue;
+                               }
                                break;
                        case 1: /* Waiting for {        */
                                if (c == '{') {
                                        state++;
                                        varname = inp;
+                                       continue;
                                } else {
                                        state = 0;
                                        append_char(pass, &outp, '$');
-                                       append_char(pass, &outp, c);
                                }
                                break;
                        case 2: /* Waiting for }        */
@@ -126,15 +186,13 @@ char *process_macros(char *input, char *output)
                                        /* Look for another '$' */
                                        state = 0;
                                }
-                               break;
+                               continue;
                        case 3: /* Waiting for '        */
-                               if ((c == '\'') && (prev != '\\'))
+                               if (c == '\'')
                                        state = 0;
-                               else
-                                       append_char(pass, &outp, c);
                                break;
                        }
-                       prev = c;
+                       append_char(pass, &outp, c);
                }
 
                append_char(pass, &outp, 0);
@@ -200,12 +258,13 @@ static int cli_run_command(const char *cmd, int flag)
                 */
                for (inquotes = 0, sep = str; *sep; sep++) {
                        if ((*sep == '\'') &&
-                           (*(sep - 1) != '\\'))
+                           (sep != str) &&                             /* past string start */
+                           (*(sep - 1) != '\\'))               /* and NOT escaped */
                                inquotes = !inquotes;
 
                        if (!inquotes &&
-                           (*sep == ';' || *sep == '\n') &&    /* separator            */
-                           (sep != str) &&                     /* past string start    */
+                           (*sep == ';' || *sep == '\n') &&    /* separator */
+                           (sep != str) &&                             /* past string start */
                            (*(sep - 1) != '\\'))               /* and NOT escaped */
                                break;
                }
@@ -257,7 +316,7 @@ static int cli_run_command_list(const char *cmd)
 
 
 /*
- * Run a command using the selected parser.
+ * Run a command.
  *
  * @param cmd  Command to run
  * @param flag Execution flags (CMD_FLAG_...)
@@ -341,7 +400,7 @@ command_ret_t do_run(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
                arg = getenv(argv[i]);
                if (arg == NULL) {
-                       printf_P(PSTR("## Error: \"%s\" not defined\n"), argv[i]);
+                       printf_P(PSTR("## Error: \"%s\" is not set\n"), argv[i]);
                        return CMD_RET_FAILURE;
                }
 
@@ -350,4 +409,3 @@ command_ret_t do_run(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
        }
        return CMD_RET_SUCCESS;
 }
-