X-Git-Url: http://cloudbase.mooo.com/gitweb/z180-stamp.git/blobdiff_plain/b08e079d1541c80028e3a11affec3f863eb9129d..1b77fa4e36e50258936a4b61fdb11a988d473b1a:/avr/cli.c?ds=sidebyside

diff --git a/avr/cli.c b/avr/cli.c
index 43b5be0..8763ed1 100644
--- a/avr/cli.c
+++ b/avr/cli.c
@@ -44,9 +44,7 @@ static int cli_parse_line(char *line, char *argv[])
 
 	debug_parser("%s: \"%s\"\n", __func__, line);
 
-	for (outp = inp = line, quote = '\0' ;
-			nargs < CONFIG_SYS_MAXARGS && (c = *inp) != '\0';
-			inp++) {
+	for (outp = inp = line, quote = '\0'; (c = *inp) != '\0'; inp++) {
 
 		switch (state) {
 		case 0:						/* before arg string, waiting for arg start */
@@ -91,6 +89,11 @@ static int cli_parse_line(char *line, char *argv[])
 			break;
 
 		}
+
+		if (nargs > CONFIG_SYS_MAXARGS) {
+			--nargs;
+			break;
+		}
 		*outp++ = c;
 	}
 
@@ -174,7 +177,7 @@ char *process_macros(char *input, char *output)
 				if (c == '}') {
 					/* Terminate variable name */
 					*(inp-1) = '\0';
-					const char *envval = getenv(varname);
+					const char *envval = getenv_char(varname);
 					*(inp-1) = '}';
 					/* Copy into the line if it exists */
 					if (envval != NULL)
@@ -207,7 +210,7 @@ char *process_macros(char *input, char *output)
  * WARNING:
  *
  * We must create a temporary copy of the command since the command we get
- * may be the result from getenv(), which returns a pointer directly to
+ * may be the result from getenv_char(), which returns a pointer directly to
  * the environment data, which may change magicly when the command we run
  * creates or modifies environment variables (like "bootp" does).
  *
@@ -395,9 +398,9 @@ command_ret_t do_run(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	for (i = 1; i < argc; ++i) {
 		char *arg;
 
-		arg = getenv(argv[i]);
+		arg = getenv_char(argv[i]);
 		if (arg == NULL) {
-			printf_P(PSTR("## Error: \"%s\" not defined\n"), argv[i]);
+			printf_P(PSTR("## Error: \"%s\" is not set\n"), argv[i]);
 			return CMD_RET_FAILURE;
 		}