X-Git-Url: http://cloudbase.mooo.com/gitweb/z180-stamp.git/blobdiff_plain/b0e4f7e5bf9f344a9ef4642a3ce3441ada206941..0dd441e803f3563839541e7526f8294032aa7743:/avr/cli.c diff --git a/avr/cli.c b/avr/cli.c index 046859c..b96ca1b 100644 --- a/avr/cli.c +++ b/avr/cli.c @@ -1,24 +1,51 @@ -#include "common.h" +/* + * (C) Copyright 2014-2016 Leo C. + * + * (C) Copyright 2000 + * Wolfgang Denk, DENX Software Engineering, wd@denx.de. + * + * Add to readline cmdline-editing by + * (C) Copyright 2005 + * JinHua Luo, GuangDong Linux Center, + * + * SPDX-License-Identifier: GPL-2.0 + */ -#include +#include "cli.h" +#include "command.h" #include -#include -#include #include "config.h" -#include "command.h" -#include "xmalloc.h" #include "debug.h" #include "env.h" #include "cli_readline.h" #include "con-utils.h" -#include "cli.h" + + +/* FIXME: Quoting problems */ #define DEBUG_PARSER 0 /* set to 1 to debug */ #define debug_parser(fmt, args...) \ debug_cond(DEBUG_PARSER, fmt, ##args) + +static bool opt_xtrace; +static bool opt_verbose; +static int_least8_t command_level; + +static void cli_trace_cmd(int_fast8_t level, int argc, char *argv[]) +{ + while (level-- > 0) + putchar('+'); + for (int_fast8_t i = 0; i < argc; i++) + printf_P(PSTR(" %s"), argv[i]); + putchar('\n'); +} + + + + static int cli_parse_line(char *line, char *argv[]) { uint_fast8_t state = 0; @@ -28,12 +55,10 @@ static int cli_parse_line(char *line, char *argv[]) debug_parser("%s: \"%s\"\n", __func__, line); - for (outp = inp = line, quote = '\0' ; - nargs < CONFIG_SYS_MAXARGS && (c = *inp) != '\0'; - inp++) { + for (outp = inp = line, quote = '\0'; (c = *inp) != '\0'; inp++) { switch (state) { - case 0: + case 0: /* before arg string, waiting for arg start */ if (isblank(c)) continue; @@ -42,7 +67,7 @@ static int cli_parse_line(char *line, char *argv[]) state = 1; /* fall thru */ - case 1: + case 1: /* in arg string, waiting for end of arg string */ if (c == '\\') { ++state; continue; @@ -58,7 +83,7 @@ static int cli_parse_line(char *line, char *argv[]) } break; - case 3: + case 3: /* in quote */ if (c == '\\' && quote == '\"') { ++state; continue; @@ -69,12 +94,17 @@ static int cli_parse_line(char *line, char *argv[]) } break; - case 2: + case 2: /* waiting for next char */ case 4: --state; break; } + + if (nargs > CONFIG_SYS_MAXARGS) { + --nargs; + break; + } *outp++ = c; } @@ -120,7 +150,12 @@ char *process_macros(char *input, char *output) outp = output; } else { int outputlen = outp - output; - outp = xrealloc(output, outputlen); + outp = realloc(output, outputlen); + if (outp == NULL) { + free(output); + output = outp; + break; + } output = outp; } @@ -158,7 +193,7 @@ char *process_macros(char *input, char *output) if (c == '}') { /* Terminate variable name */ *(inp-1) = '\0'; - const char *envval = getenv(varname); + const char *envval = getenv_str(varname); *(inp-1) = '}'; /* Copy into the line if it exists */ if (envval != NULL) @@ -191,7 +226,7 @@ char *process_macros(char *input, char *output) * WARNING: * * We must create a temporary copy of the command since the command we get - * may be the result from getenv(), which returns a pointer directly to + * may be the result from getenv_str(), which returns a pointer directly to * the environment data, which may change magicly when the command we run * creates or modifies environment variables (like "bootp" does). * @@ -201,7 +236,7 @@ char *process_macros(char *input, char *output) * @returns * */ -static int cli_run_command(const char *cmd, int flag) +static int cli_run_command(const char *cmd, uint_fast8_t flag) { char *cmdbuf; /* working copy of cmd */ char *token; /* start of token in cmdbuf */ @@ -213,9 +248,20 @@ static int cli_run_command(const char *cmd, int flag) uint_fast8_t inquotes, repeatable = 1; int rc = 0; + opt_verbose = 0; + opt_xtrace = 0; + char *optenv = getenv_str(PSTR("cli")); + if (optenv) { + opt_verbose = (strstr_P(optenv, PSTR("verbose")) != NULL); + opt_xtrace = (strstr_P(optenv, PSTR("xtrace")) != NULL); + } + debug_parser("[RUN_COMMAND] cmd[%p]=\"%s\"\n", cmd, cmd ? cmd : "NULL"); + if (opt_verbose) + printf_P(PSTR("%s\n"), cmd, cmd ? cmd : ""); + clear_ctrlc(); /* forget any previous Control C */ if (!cmd || !*cmd) @@ -225,6 +271,7 @@ static int cli_run_command(const char *cmd, int flag) if (!cmdbuf) return -1; /* not enough memory */ + ++command_level; str = cmdbuf; /* Process separators and check for invalid @@ -239,30 +286,38 @@ static int cli_run_command(const char *cmd, int flag) */ for (inquotes = 0, sep = str; *sep; sep++) { if ((*sep == '\'') && - (*(sep - 1) != '\\')) + (sep != str) && /* past string start */ + (*(sep - 1) != '\\')) /* and NOT escaped */ inquotes = !inquotes; if (!inquotes && - (*sep == ';' || *sep == '\n') && /* separator */ - (sep != str) && /* past string start */ - (*(sep - 1) != '\\')) /* and NOT escaped */ + (*sep == ';' || *sep == '\n' /* separator */ + || *sep == '#') && /* or start of comment */ + ((sep == str) || /* string start */ + (*(sep - 1) != '\\'))) /* or NOT escaped */ break; } - /* - * Limit the token to data between separators - */ + /* no more commands after unescaped '#' token */ + if (*sep == '#') + *sep = '\0'; + + /* Limit the token to data between separators */ token = str; if (*sep) { - str = sep + 1; /* start of command for next pass */ + str = sep + 1; /* start of command for next pass */ *sep = '\0'; } else { - str = sep; /* no more commands for next pass */ + str = sep; /* no more commands for next pass */ } debug_parser("token: \"%s\"\n", token); /* find macros in this token and replace them */ finaltoken = process_macros(token, finaltoken); + if (finaltoken == NULL) { + rc = -1; /* no command at all */ + break; + } /* Extract arguments */ argc = cli_parse_line(finaltoken, argv); @@ -271,8 +326,15 @@ static int cli_run_command(const char *cmd, int flag) continue; } - if (cmd_process(flag, argc, argv, &repeatable) != CMD_RET_SUCCESS) + if (opt_xtrace) + cli_trace_cmd(command_level, argc, argv); + + rc = cmd_process(flag, argc, argv, &repeatable); + if (rc != CMD_RET_SUCCESS) { + if (opt_verbose) + printf_P(PSTR("Command failed, result=%d\n"), rc); rc = -1; + } /* Did the user stop this? */ if (had_ctrlc()) { @@ -283,6 +345,7 @@ static int cli_run_command(const char *cmd, int flag) free(cmdbuf); free(finaltoken); + --command_level; return rc ? rc : repeatable; } @@ -296,13 +359,13 @@ static int cli_run_command_list(const char *cmd) /* - * Run a command using the selected parser. + * Run a command. * * @param cmd Command to run * @param flag Execution flags (CMD_FLAG_...) * @return 0 on success, or != 0 on error. */ -int run_command(const char *cmd, int flag) +int run_command(const char *cmd, uint_fast8_t flag) { /* * cli_run_command can return 0 or 1 for success, so clean up @@ -321,7 +384,7 @@ int run_command(const char *cmd, int flag) * @param flag Execution flags (CMD_FLAG_...) * @return 0 (not repeatable) or 1 (repeatable) on success, -1 on error. */ -static int run_command_repeatable(const char *cmd, int flag) +static int run_command_repeatable(const char *cmd, uint_fast8_t flag) { return cli_run_command(cmd, flag); } @@ -340,11 +403,11 @@ void cli_loop(void) { char *lastcommand = NULL; int len; - int flag; + uint_fast8_t flag; int rc = 1; for (;;) { - len = cli_readline(PSTR(CONFIG_SYS_PROMPT)); + len = cli_readline(lastcommand ? PSTR(CONFIG_SYS_PROMPT_REPEAT) : PSTR(CONFIG_SYS_PROMPT), 1); flag = 0; /* assume no special flags for now */ if (len > 0) { @@ -353,9 +416,10 @@ void cli_loop(void) } else if (len == 0) flag |= CMD_FLAG_REPEAT; - if (len == -1) - my_puts_P(PSTR("\n")); - else + if (len == -1) { + if (opt_verbose) + my_puts_P(PSTR("\n")); + } else rc = run_command_repeatable(lastcommand, flag); if (rc <= 0) { @@ -365,27 +429,3 @@ void cli_loop(void) } } } - - -command_ret_t do_run(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) -{ - int i; - (void) cmdtp; - - if (argc < 2) - return CMD_RET_USAGE; - - for (i = 1; i < argc; ++i) { - char *arg; - - arg = getenv(argv[i]); - if (arg == NULL) { - printf_P(PSTR("## Error: \"%s\" not defined\n"), argv[i]); - return CMD_RET_FAILURE; - } - - if (run_command(arg, flag) != 0) - return CMD_RET_FAILURE; - } - return CMD_RET_SUCCESS; -}