-Wimplicit-fallthrough=1

diff --git a/avr/cmd_boot.c b/avr/cmd_boot.c
index fb533c73a3ca9ea8e977a76ea1decf5054d25456..bba510f54c7d685c7bb91c48cd6c3355c7476b95 100644 (file)
--- a/avr/cmd_boot.c
+++ b/avr/cmd_boot.c
@@ -379,6 +379,7 @@ command_ret_t do_console(cmd_tbl_t *cmdtp UNUSED, uint_fast8_t flag UNUSED, int
                        case 2:
                                my_puts_P(PSTR("\n"
                                  "------------------------------------------------\n"));
+                               /* FALL TROUGH */
                        case 1:
                                state = 0;
                                switch (toupper(ch)) {

diff --git a/avr/cmd_gpio.c b/avr/cmd_gpio.c
index 549654fdf1c6e24da59512d87bff73ab2d71ba11..32bd53ad8f9d95d50b33a2c42d05909278faeecd 100644 (file)
--- a/avr/cmd_gpio.c
+++ b/avr/cmd_gpio.c
@@ -247,6 +247,7 @@ command_ret_t do_gpio(cmd_tbl_t *cmdtp UNUSED, uint_fast8_t flag UNUSED, int arg
                switch (toupper(argv[optind][0])) {
                case 'H':
                        level = 1;
+                       /* FALL TROUGH */
                case 'L':
                        mode = OUTPUT;
                        break;
@@ -263,6 +264,7 @@ command_ret_t do_gpio(cmd_tbl_t *cmdtp UNUSED, uint_fast8_t flag UNUSED, int arg
                        switch (*endp) {
                        case 'M':
                                value *= 1000;
+                               /* FALL TROUGH */
                        case 'K':
                                value *= 1000;
                                endp++;

diff --git a/avr/env.c b/avr/env.c
index 671d1c4c9c88a267ca577713d446a32131e9570b..900f68979fdc7e2e087a0ace578c8e288d528b98 100644 (file)
--- a/avr/env.c
+++ b/avr/env.c
@@ -63,6 +63,7 @@ char env_get_char(uint_fast16_t index)
        switch (env_valid) {
        case 2:
                off += CONFIG_ENV_SIZE;
+               /* FALL TROUGH */
        case 1:
                ret = (char) eeprom_read_byte((const uint8_t *)off + index +
                                offsetof(env_t, data));

diff --git a/avr/gpio.c b/avr/gpio.c
index 73e9c396cad46d26235270e01e296552f7d939c3..6f73ceea222b6916dab915a0666343e244aa30b5 100644 (file)
--- a/avr/gpio.c
+++ b/avr/gpio.c
@@ -148,6 +148,7 @@ int gpio_config(int pin, gpiomode_t mode)
                        break;
                case OUTPUT:
                        gpio_timer_off(pinlist[pin].timer);
+                       /* FALL TROUGH */
                case OUTPUT_TIMER:
                        ATOMIC_BLOCK(ATOMIC_FORCEON) {
                                p->ddr |= bit;

diff --git a/include/errnum.h b/include/errnum.h
index 628c4323af2a8f9b3dd997ec5e794b6aeca5d66e..5faa65cc01fe657d96cb5ac64b5fc23d6878ecc0 100644 (file)
--- a/include/errnum.h
+++ b/include/errnum.h
@@ -11,18 +11,19 @@
 
 typedef enum {
        ESUCCESS        = 0,
-       ENOMEM          = 101,
-       EINTR,
-       EBUSTO,
-       EUNEXPARG,
-       EATRANGE,
-       EATALRDY,
-       EATNOT,
-       EATOPEN,
-       EATOTHER,
-       ERUNNING,
-       EINVAL,
-       EEOF,
+                                                       // Unknown error
+       ENOMEM          = 101,          // Not enough memory
+       EINTR,                  // Interrupt
+       EBUSTO,                 // Bus timeout
+       EUNEXPARG,              // Unexpected argument
+       EATRANGE,               // Invalid disk number
+       EATALRDY,               // Disk already attached
+       EATNOT,                 // Disk not attached
+       EATOPEN,                // Error opening file
+       EATOTHER,               // File already attached to other drive
+       ERUNNING,               // CPU is running
+       EINVAL,                 // Invalid argument
+       EEOF,                   // Unexpected EOF
 
 } ERRNUM;
 

diff --git a/mk/avr.rules.mk b/mk/avr.rules.mk
index 66fab582ebba8d9563c747a38f2451ffe63e87a2..97d9fdf2e313e8c6837ad1e69146c8d20021f337 100644 (file)
--- a/mk/avr.rules.mk
+++ b/mk/avr.rules.mk
@@ -33,7 +33,7 @@ OBJ = $(SRC:.c=.o) $(ASRC:.S=.o)
 
 TGT_CFLAGS     += -mmcu=$(MCU) $(OPT) $(CSTD) -g
 TGT_CFLAGS     += $(ARCH_FLAGS)
-TGT_CFLAGS     += -Wextra -Wshadow -Wimplicit-function-declaration
+TGT_CFLAGS     += -Wextra -Wshadow -Wimplicit-function-declaration -Wimplicit-fallthrough=1
 TGT_CFLAGS     += -Wredundant-decls -Wstrict-prototypes
 TGT_CFLAGS     += -fshort-enums -funsigned-bitfields
 TGT_CFLAGS     += -fno-common -ffunction-sections -fdata-sections